tdd-java-demo

commit fcaf8ce4967bb5299d68a74d06a37233a93436c7
parent 23e40fe41ed2cf7b27120a6fda9303b225250b60
Author: Jul <jul@9o.is>
Date:   Wed, 31 Mar 2021 19:08:19 +0800

rename variables and methods in DiscountTest

Diffstat:
M
src/test/java/takehome/DiscountTest.java
 | 
24
++++++++++++++----------

1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/src/test/java/takehome/DiscountTest.java b/src/test/java/takehome/DiscountTest.java
@@ -11,39 +11,43 @@ import static org.hamcrest.Matchers.is;
 class DiscountTest {
 
     public static final Item APPLE = new Item("apple", 0.10);
-    public static final Discount DISCOUNT = new Discount(0.01, APPLE);
+    public static final Discount APPLE_DISCOUNT = createAppleDiscount();
 
     @Test
     void getItem() {
-        assertThat(DISCOUNT.getItem(), is(APPLE));
+        assertThat(APPLE_DISCOUNT.getItem(), is(APPLE));
     }
 
     @Test
     void getAmount() {
-        assertThat(DISCOUNT.getAmount(), is(0.01));
+        assertThat(APPLE_DISCOUNT.getAmount(), is(0.01));
     }
 
     @Test
     void noDiscount() {
-        Basket basket = createBasket(0);
-        assertThat(DISCOUNT.getDiscount(basket), is(0d));
+        Basket basket = createBasketWithApples(0);
+        assertThat(APPLE_DISCOUNT.getDiscount(basket), is(0d));
     }
 
     @Test
     void oneDiscount() {
-        Basket basket = createBasket(1);
-        assertThat(DISCOUNT.getDiscount(basket), is(0.01));
+        Basket basket = createBasketWithApples(1);
+        assertThat(APPLE_DISCOUNT.getDiscount(basket), is(0.01));
     }
 
     @Test
     void multipleDiscounts() {
-        Basket basket = createBasket(2);
-        assertThat(DISCOUNT.getDiscount(basket), is(0.02));
+        Basket basket = createBasketWithApples(2);
+        assertThat(APPLE_DISCOUNT.getDiscount(basket), is(0.02));
     }
 
-    private Basket createBasket(int amount) {
+    private Basket createBasketWithApples(int amount) {
         Map<Item, Integer> amounts = new HashMap<>();
         amounts.put(APPLE, amount);
         return new Basket(amounts);
     }
+
+    private static Discount createAppleDiscount() {
+        return new Discount(0.01, APPLE);
+    }
 }
 \ No newline at end of file