tdd-java-demo

commit 3f7d20c50b9f603548d00dd2fcea0c55d49ce5a0
parent 03e08a86e5c5449bcef12f5ac83980e3ac3207cd
Author: Jul <jul@9o.is>
Date:   Thu,  1 Apr 2021 02:18:10 +0800

extract method createBasket in BasketTest

Diffstat:
M
src/test/java/takehome/BasketTest.java
 | 
16
+++++++---------

1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/src/test/java/takehome/BasketTest.java b/src/test/java/takehome/BasketTest.java
@@ -19,20 +19,19 @@ class BasketTest {
 
     @Test
     public void getAmounts() {
-        Map<Item, Integer> amounts = getItemAmounts();
-        Basket basket = new Basket(amounts);
+        Basket basket = createBasket();
         assertThat(basket.getItems(), is(items()));
     }
 
     @Test
     public void getTotal() {
-        Basket basket = new Basket(getItemAmounts());
+        Basket basket = createBasket();
         assertThat(basket.getTotal(), is(2.25));
     }
 
     @Test
     public void getAmount() {
-        Basket basket = new Basket(getItemAmounts());
+        Basket basket = createBasket();
         assertThat(basket.getAmount(BREAD), is(2));
     }
 
@@ -40,7 +39,7 @@ class BasketTest {
     public void getTotalWithDiscounts() {
         Discount discount = new Discount(0.40, SOUP, BREAD, BREAD);
         Discount[] discounts = { discount };
-        Basket basket = new Basket(getItemAmounts());
+        Basket basket = createBasket();
 
         assertThat(basket.getTotal(discounts), is(1.85));
     }
@@ -51,7 +50,7 @@ class BasketTest {
         LocalDate tomorrow = today.plusDays(1);
         LocalDate yesterday = today.minusDays(1);
 
-        Basket basket = new Basket(getItemAmounts());
+        Basket basket = createBasket();
         basket.setPurchaseDate(tomorrow);
         Discount[] discounts = {
                 new Discount(0.40, yesterday, today, SOUP, BREAD, BREAD)
@@ -60,16 +59,15 @@ class BasketTest {
         assertThat(basket.getTotal(discounts), is(2.25));
     }
 
-    private Map<Item, Integer> getItemAmounts() {
+    private Basket createBasket() {
         Map<Item, Integer> amounts = new HashMap<>();
         amounts.put(SOUP, 1);
         amounts.put(BREAD, 2);
 
-        return amounts;
+        return new Basket(amounts);
     }
 
     private Multiset<Item> items() {
         return HashMultiset.create(Arrays.asList(SOUP, BREAD, BREAD));
     }
-
 }
 \ No newline at end of file