tdd-java-demo

commit 3499f695ebe17888a3b86751e89b3eba4ca2b6d4
parent f9ae724b648ccdf5e2e487cdb3207b4e03b02290
Author: Jul <jul@9o.is>
Date:   Thu,  1 Apr 2021 00:48:43 +0800

invalidate discount after end date

Diffstat:
M
src/main/java/takehome/Discount.java
 | 
2
+-
M
src/test/java/takehome/DiscountTest.java
 | 
6
++++++

2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/main/java/takehome/Discount.java b/src/main/java/takehome/Discount.java
@@ -46,6 +46,6 @@ public class Discount {
 
     public boolean isValid(LocalDate date) {
         return date.equals(startDate) || date.equals(endDate) ||
-                date.isAfter(startDate);
+                (date.isAfter(startDate) && date.isBefore(endDate));
     }
 }
diff --git a/src/test/java/takehome/DiscountTest.java b/src/test/java/takehome/DiscountTest.java
@@ -93,6 +93,12 @@ class DiscountTest {
         assertThat(discount.isValid(TODAY), is(true));
     }
 
+    @Test
+    void isInvalidAfterEndDate() {
+        Discount discount = discountByDate(YESTERDAY, TODAY);
+        assertThat(discount.isValid(TOMORROW), is(false));
+    }
+
     private Discount discountByDate(LocalDate startDate, LocalDate endDate) {
         return new Discount(0.01, startDate, endDate, APPLE);
     }