dwm, branch HEAD

handle potato-c time increase/decrease with scrollwheel

2026-02-19T23:44:44Z

commit d804eb1ea81b439eee63b404b2c07f252e79b09a parent fbd08a4b0bbc12827fee1f88a5a09421f952f09c Author: Jul Date: Fri, 20 Feb 2026 07:44:44 +0800 handle potato-c time increase/decrease with scrollwheel

fix net active focus in deck layout

2026-02-19T16:38:47Z

commit fbd08a4b0bbc12827fee1f88a5a09421f952f09c parent 1b40bd044bade427e6c153e767ed0802252183da Author: Jul Date: Fri, 20 Feb 2026 00:38:47 +0800 fix net active focus in deck layout

add dmenu-lsw shortcut

2026-02-19T14:45:29Z

commit 1b40bd044bade427e6c153e767ed0802252183da parent a438297a487a975fbe016e7b3e2f4b06d1a5c83b Author: Jul Date: Thu, 19 Feb 2026 22:45:29 +0800 add dmenu-lsw shortcut

focus on window activation

2026-02-19T09:18:31Z

commit a438297a487a975fbe016e7b3e2f4b06d1a5c83b parent 967407d6f94acd6bc27e686b813ff21aa6db2585 Author: Jul Date: Thu, 19 Feb 2026 17:18:31 +0800 focus on window activation

use resizeclient for tile and deck layouts

2026-02-17T17:42:07Z

commit 967407d6f94acd6bc27e686b813ff21aa6db2585 parent 0d4db2bfab9a9d6e3b2f581bca12d28f4b40b972 Author: Jul Date: Wed, 18 Feb 2026 01:42:07 +0800 use resizeclient for tile and deck layouts

Revert "add swallow"

2026-02-17T17:16:17Z

commit 0d4db2bfab9a9d6e3b2f581bca12d28f4b40b972 parent a7d088a93272e2b0e960a2183440bd51cb3c8661 Author: Jul Date: Wed, 18 Feb 2026 01:16:17 +0800 Revert "add swallow" This reverts commit 0e10a0df3a901b5f26300ae4f9f19e71f9c0cfcf.

fix monocle smartborders

2026-02-17T16:50:22Z

commit a7d088a93272e2b0e960a2183440bd51cb3c8661 parent f04dfcd36bf666e040ab5bb8417052eb273c71ca Author: Jul Date: Wed, 18 Feb 2026 00:50:22 +0800 fix monocle smartborders

fix null pointer error

2026-02-16T04:07:37Z

commit f04dfcd36bf666e040ab5bb8417052eb273c71ca parent ed424e1e466738606ce2c148104b3cf7a4551c19 Author: Jul Date: Mon, 16 Feb 2026 12:07:37 +0800 fix null pointer error

warp cursor in missing actions

2026-02-16T00:08:17Z

commit ed424e1e466738606ce2c148104b3cf7a4551c19 parent a8f1cea537b87ff32e93b311ace0d2ff6f3fba10 Author: Jul Date: Mon, 16 Feb 2026 08:08:17 +0800 warp cursor in missing actions

add custom qubes-clipboard shortcuts

2026-02-15T15:09:20Z

commit a8f1cea537b87ff32e93b311ace0d2ff6f3fba10 parent 7962c42fc0a504a631789fb8434015f9cc68bcb4 Author: Jul Date: Sun, 15 Feb 2026 10:09:20 -0500 add custom qubes-clipboard shortcuts

toggle potato-c on status click

2026-02-05T22:54:14Z

commit 7962c42fc0a504a631789fb8434015f9cc68bcb4 parent 027c260fcd2045747823774862c9ce45fbec099c Author: Jul Date: Thu, 5 Feb 2026 17:54:14 -0500 toggle potato-c on status click

add brightness dmenu prompt

2026-02-04T13:33:28Z

commit 027c260fcd2045747823774862c9ce45fbec099c parent 2e6c9b7727434a65a4a802e553c57dc9fdcff922 Author: Jul Date: Wed, 4 Feb 2026 08:33:28 -0500 add brightness dmenu prompt

add volume keybindings

2026-02-04T13:25:29Z

commit 2e6c9b7727434a65a4a802e553c57dc9fdcff922 parent 783cb1389e50d78789de717d992b457f8976e3a2 Author: Jul Date: Wed, 4 Feb 2026 08:25:29 -0500 add volume keybindings

add dmenu commands

2026-02-04T12:50:08Z

commit 783cb1389e50d78789de717d992b457f8976e3a2 parent 4fdfeb53836e466df72ca619a16c2f3eb1d675be Author: Jul Date: Wed, 4 Feb 2026 07:50:08 -0500 add dmenu commands

remove monacle layout number in status bar

2026-02-04T11:56:52Z

commit 4fdfeb53836e466df72ca619a16c2f3eb1d675be parent 0e10a0df3a901b5f26300ae4f9f19e71f9c0cfcf Author: Jul Date: Wed, 4 Feb 2026 06:56:52 -0500 remove monacle layout number in status bar

add swallow

2026-02-04T01:09:00Z

commit 0e10a0df3a901b5f26300ae4f9f19e71f9c0cfcf parent c566b48938b44ad5356c1e6b2374fdf50c364a8f Author: Jul Date: Tue, 3 Feb 2026 20:09:00 -0500 add swallow

try different mod masks for navigating wins/tags

2026-02-04T00:45:37Z

commit c566b48938b44ad5356c1e6b2374fdf50c364a8f parent 733f1a5b0a75ed18b90ccce94ebb5ad1d2bf8c6c Author: Jul Date: Tue, 3 Feb 2026 19:45:37 -0500 try different mod masks for navigating wins/tags

navigate focusstack from foreground

2026-02-03T17:56:12Z

commit 733f1a5b0a75ed18b90ccce94ebb5ad1d2bf8c6c parent dc1a72dc6f0c9d2e235963f2d6b9ce4828274832 Author: Jul Date: Tue, 3 Feb 2026 12:56:12 -0500 navigate focusstack from foreground

add simple foregrounded windows

2026-02-03T10:28:01Z

commit dc1a72dc6f0c9d2e235963f2d6b9ce4828274832 parent 0be9ada01efc9b588de5af0564e792315b32c6fe Author: Jul Date: Tue, 3 Feb 2026 05:28:01 -0500 add simple foregrounded windows

remove original foregrounded feature

2026-02-03T08:31:11Z

commit 0be9ada01efc9b588de5af0564e792315b32c6fe parent 5587534f9bab8f70e323d9d68da9c3bacc3b5d24 Author: Jul Date: Tue, 3 Feb 2026 03:31:11 -0500 remove original foregrounded feature

arrow keys navigates windows in foreground

2026-02-02T17:18:47Z

commit 5587534f9bab8f70e323d9d68da9c3bacc3b5d24 parent 6befce5359a4667dcb9e82b0c13119ece7d9a8f8 Author: Jul Date: Mon, 2 Feb 2026 12:18:47 -0500 arrow keys navigates windows in foreground

always set border around foreground window

2026-02-02T16:22:27Z

commit 6befce5359a4667dcb9e82b0c13119ece7d9a8f8 parent e0891f37cd0ef92ef7832698a212c696297b625b Author: Jul Date: Mon, 2 Feb 2026 11:22:27 -0500 always set border around foreground window

set Mod-minus to toggle foreground

2026-02-02T16:14:17Z

commit e0891f37cd0ef92ef7832698a212c696297b625b parent ac6d133842c02cb0d9205f49c0dda2f547905d70 Author: Jul Date: Mon, 2 Feb 2026 11:14:17 -0500 set Mod-minus to toggle foreground

enlarge foreground window

2026-02-02T15:42:34Z

commit ac6d133842c02cb0d9205f49c0dda2f547905d70 parent 47fcde2d1a1036458e7decd8dfd25a06fb20a36a Author: Jul Date: Mon, 2 Feb 2026 10:42:34 -0500 enlarge foreground window

set incnmaster/setmfact to up/down arrow keys

2026-02-02T12:33:03Z

commit 47fcde2d1a1036458e7decd8dfd25a06fb20a36a parent 2915fc7847bde79e56cab705cead777f05cc729b Author: Jul Date: Mon, 2 Feb 2026 07:33:03 -0500 set incnmaster/setmfact to up/down arrow keys

remove toggle floating keybinding

2026-02-02T12:09:48Z

commit 2915fc7847bde79e56cab705cead777f05cc729b parent 843a1be3814ba444bff9f60b8b26f28377492f3c Author: Jul Date: Mon, 2 Feb 2026 07:09:48 -0500 remove toggle floating keybinding

default to deck layout

2026-02-02T12:06:38Z

commit 843a1be3814ba444bff9f60b8b26f28377492f3c parent 25c5922fb9dcc246af6e0107c11f84d8c49b62fe Author: Jul Date: Mon, 2 Feb 2026 07:06:38 -0500 default to deck layout

reorganize nav keys with NUMKEYS and DIRKEYS macros

2026-02-02T12:01:19Z

commit 25c5922fb9dcc246af6e0107c11f84d8c49b62fe parent 787f5526c735bbaf7115b4089c7b807faaaa0613 Author: Jul Date: Mon, 2 Feb 2026 07:01:19 -0500 reorganize nav keys with NUMKEYS and DIRKEYS macros

navigate clients with numbers and tags with symbols

2026-02-02T10:43:03Z

commit 787f5526c735bbaf7115b4089c7b807faaaa0613 parent d52905cf5305c0d0d194013765214c119f338b18 Author: Jul Date: Mon, 2 Feb 2026 05:43:03 -0500 navigate clients with numbers and tags with symbols

add deck layout

2026-02-02T06:19:03Z

commit d52905cf5305c0d0d194013765214c119f338b18 parent 355d67d850a51d7b6cad9472b73be74baae9df5a Author: Jul Date: Mon, 2 Feb 2026 01:19:03 -0500 add deck layout

allow foregrounding windows

2026-02-02T03:56:38Z

commit 355d67d850a51d7b6cad9472b73be74baae9df5a parent ea8c34c2847ded9c917187a53c79f9118d1630cc Author: Jul Date: Sun, 1 Feb 2026 22:56:38 -0500 allow foregrounding windows

allow window to set status in status bar

2026-02-02T01:46:05Z

commit ea8c34c2847ded9c917187a53c79f9118d1630cc parent f377abd9a334289a95c26b1cbfb2fb6fdb3fe360 Author: Jul Date: Sun, 1 Feb 2026 20:46:05 -0500 allow window to set status in status bar

warp cursor on changing window, monitor, etc.

2026-02-01T21:31:03Z

commit f377abd9a334289a95c26b1cbfb2fb6fdb3fe360 parent 4caaadf342e067a73f4909038a98aaff19bd0815 Author: Jul Date: Sun, 1 Feb 2026 16:31:03 -0500 warp cursor on changing window, monitor, etc.

move client counter to the left of tags

2026-02-01T21:17:50Z

commit 4caaadf342e067a73f4909038a98aaff19bd0815 parent f7d68a02b873c79ccdbae3ff864e2b7e885aa4df Author: Jul Date: Sun, 1 Feb 2026 16:17:50 -0500 move client counter to the left of tags

prefix qubes vm name to title

2026-02-01T21:02:48Z

commit f7d68a02b873c79ccdbae3ff864e2b7e885aa4df parent b003c69b9edc7dd9c838ef1259c8cf8f4f632407 Author: Jul Date: Sun, 1 Feb 2026 16:02:48 -0500 prefix qubes vm name to title

apply smart borders

2026-02-01T20:02:34Z

commit b003c69b9edc7dd9c838ef1259c8cf8f4f632407 parent 668d49ea1069e1b28ff6115a8278916e36bdc00c Author: Jul Date: Sun, 1 Feb 2026 15:02:34 -0500 apply smart borders

remove padding from client counter

2026-02-01T18:34:41Z

commit 668d49ea1069e1b28ff6115a8278916e36bdc00c parent 242270fe2c781c1c4c72bd8e975731cd91abde55 Author: Jul Date: Sun, 1 Feb 2026 13:34:41 -0500 remove padding from client counter

move client counter to the right of tags

2026-02-01T18:28:23Z

commit 242270fe2c781c1c4c72bd8e975731cd91abde55 parent 7bac5fda8600ce6c3023b54e5429f542b1077205 Author: Jul Date: Sun, 1 Feb 2026 13:28:23 -0500 move client counter to the right of tags

show client counter in status bar

2026-02-01T18:16:50Z

commit 7bac5fda8600ce6c3023b54e5429f542b1077205 parent d06b882e7bdab48dc2641e76df792b12341f0450 Author: Jul Date: Sun, 1 Feb 2026 13:16:50 -0500 show client counter in status bar

create TEXTWNP macro

2026-02-01T16:55:45Z

commit d06b882e7bdab48dc2641e76df792b12341f0450 parent 39769100aefafecc462b254a3e0ceb8775674612 Author: Jul Date: Sun, 1 Feb 2026 11:55:45 -0500 create TEXTWNP macro

remove left/right padding from tags

2026-02-01T16:52:56Z

commit 39769100aefafecc462b254a3e0ceb8775674612 parent 7b50e933e52ee7c5a503868f5f3067b052437bf4 Author: Jul Date: Sun, 1 Feb 2026 11:52:56 -0500 remove left/right padding from tags

set default status text to empty string

2026-02-01T16:03:18Z

commit 7b50e933e52ee7c5a503868f5f3067b052437bf4 parent 1fadbb4d890bcf7e602a691eb7a341231dae614a Author: Jul Date: Sun, 1 Feb 2026 11:03:18 -0500 set default status text to empty string

hide vacant tags

2026-02-01T15:57:55Z

commit 1fadbb4d890bcf7e602a691eb7a341231dae614a parent 69deb34ee7fd25c732980cb4ef7f2e32e9d344cb Author: Jul Date: Sun, 1 Feb 2026 10:57:55 -0500 hide vacant tags

set selected color scheme to blue on black

2026-02-01T15:25:39Z

commit 69deb34ee7fd25c732980cb4ef7f2e32e9d344cb parent 4e2dd4017ea448f36b15a5d379e4c87d030c0f87 Author: Jul Date: Sun, 1 Feb 2026 10:25:39 -0500 set selected color scheme to blue on black

move window title to lhs of status bar

2026-02-01T15:03:07Z

commit 4e2dd4017ea448f36b15a5d379e4c87d030c0f87 parent 47c3168baee7b4a80c02f3f459f01425f1ea6b18 Author: Jul Date: Sun, 1 Feb 2026 10:03:07 -0500 move window title to lhs of status bar

dont color window title in status bar

2026-02-01T11:50:14Z

commit 47c3168baee7b4a80c02f3f459f01425f1ea6b18 parent 04d5afbd628ccfe3cd84c123e44080d13d5ddc5e Author: Jul Date: Sun, 1 Feb 2026 06:50:14 -0500 dont color window title in status bar

reverse color for selected scheme

2026-02-01T11:43:11Z

commit 04d5afbd628ccfe3cd84c123e44080d13d5ddc5e parent c421d4ddda82d2e0a60c50c38d0fa5282c539f12 Author: Jul Date: Sun, 1 Feb 2026 06:43:11 -0500 reverse color for selected scheme

remove monitor bindings

2026-02-01T11:34:15Z

commit c421d4ddda82d2e0a60c50c38d0fa5282c539f12 parent a073e2a99bda40c5b99a6961e5104252b93818ee Author: Jul Date: Sun, 1 Feb 2026 06:34:15 -0500 remove monitor bindings

switch C-M-q binding to kill client

2026-02-01T11:28:55Z

commit a073e2a99bda40c5b99a6961e5104252b93818ee parent da172930d0f10cb05caa0ef8bf9d6ec5ad14d432 Author: Jul Date: Sun, 1 Feb 2026 06:28:55 -0500 switch C-M-q binding to kill client

switch focusstack bindings to arrow keys

2026-02-01T11:26:47Z

commit da172930d0f10cb05caa0ef8bf9d6ec5ad14d432 parent 3d7a1c10462943750c3f956f702f496ce95a3fa0 Author: Jul Date: Sun, 1 Feb 2026 06:26:47 -0500 switch focusstack bindings to arrow keys

shift windows between adjacent tags

2026-02-01T10:59:26Z

commit 3d7a1c10462943750c3f956f702f496ce95a3fa0 parent fe2016cebab48bf43e62b51a7136f65b045a477e Author: Jul Date: Sun, 1 Feb 2026 05:59:26 -0500 shift windows between adjacent tags

fix zenity rule

2026-02-01T09:00:54Z

commit fe2016cebab48bf43e62b51a7136f65b045a477e parent 8066adbbeb8bb12244e4494312b364f9f70c244e Author: Jul Date: Sun, 1 Feb 2026 04:00:54 -0500 fix zenity rule

preserve clients on old tags when restarting

2026-02-01T08:52:16Z

commit 8066adbbeb8bb12244e4494312b364f9f70c244e parent 9fe72f38758c54ecad1af757a3729043ddb95e91 Author: Jul Date: Sun, 1 Feb 2026 03:52:16 -0500 preserve clients on old tags when restarting

always center floating windows

2026-02-01T08:20:08Z

commit 9fe72f38758c54ecad1af757a3729043ddb95e91 parent 5bfe0d167b6b0ada88f0b9aa25f2369eb4711850 Author: Jul Date: Sun, 1 Feb 2026 03:20:08 -0500 always center floating windows

force zenity windows to float

2026-02-01T08:14:13Z

commit 5bfe0d167b6b0ada88f0b9aa25f2369eb4711850 parent 2f2720447dcaee06fb64bd0239d1d3d7741009ea Author: Jul Date: Sun, 1 Feb 2026 03:14:13 -0500 force zenity windows to float

change normal border to visible gray

2026-02-01T08:06:22Z

commit 2f2720447dcaee06fb64bd0239d1d3d7741009ea parent e6e2cca529a2e51abb21ccbc410363a7c3df183a Author: Jul Date: Sun, 1 Feb 2026 03:06:22 -0500 change normal border to visible gray

handle term and hup signals

2026-02-01T07:19:44Z

commit e6e2cca529a2e51abb21ccbc410363a7c3df183a parent 0b4cafb297403ec0cef951441969bfdd270a8990 Author: Jul Date: Sun, 1 Feb 2026 02:19:44 -0500 handle term and hup signals

update default configs

2026-01-31T14:34:56Z

commit 0b4cafb297403ec0cef951441969bfdd270a8990 parent 140506c1c4f4f2bf7a5026b85f2d6d0ca16ae8d9 Author: Jul Date: Sat, 31 Jan 2026 09:34:56 -0500 update default configs

save config.h

2026-01-30T07:22:45Z

commit 140506c1c4f4f2bf7a5026b85f2d6d0ca16ae8d9 parent be9bcc2f8c31af19baaa2bef2363ae12162ffe9f Author: Jul Date: Fri, 30 Jan 2026 02:22:45 -0500 save config.h

gitignore objects and dwm binary

2026-01-30T07:22:14Z

commit be9bcc2f8c31af19baaa2bef2363ae12162ffe9f parent ed43b62a3d2778eb0cfd164d61e9cf04cf86c81c Author: Jul Date: Fri, 30 Jan 2026 02:22:14 -0500 gitignore objects and dwm binary

dwm: Fix getatomprop regression from heap overflow fix

2026-01-14T06:58:05Z

commit ed43b62a3d2778eb0cfd164d61e9cf04cf86c81c parent bb24d4d279d5c0887d7cb471d0e988e4c2dce5a8 Author: Chris Down Date: Wed, 14 Jan 2026 14:58:05 +0800 dwm: Fix getatomprop regression from heap overflow fix Commit bf9cffa1f721 ("dwm: Fix heap buffer overflow in getatomprop") introduced a check for dl > 0 before dereferencing the property pointer. However, I missed that the variable dl is passed to XGetWindowProperty for both nitems_return and bytes_after_return parameters: XGetWindowProperty(..., &dl, &dl, &p) The final value in dl is bytes_after_return, not nitems_return. For a successfully read property, bytes_after is typically 0 (indicating all data was retrieved), so the check `dl > 0` is always false and dwm never reads any atom properties. So this is safe, but not very helpful :-) dl is probably just a dummy variable anyway, so fix by using a separate variable for nitems, and check nitems > 0 as originally intended.

bump version to 6.7

2026-01-10T10:31:44Z

commit bb24d4d279d5c0887d7cb471d0e988e4c2dce5a8 parent bf9cffa1f7212be6617f6bb821ebf297866f7859 Author: Hiltjo Posthuma Date: Sat, 10 Jan 2026 11:31:44 +0100 bump version to 6.7 Put the maintainer at the top and bump years (time flies).

dwm: Fix heap buffer overflow in getatomprop

2026-01-07T14:02:00Z

commit bf9cffa1f7212be6617f6bb821ebf297866f7859 parent 50a1f3442edda4ce0d544f71fe0a7bb52917783b Author: Chris Down Date: Wed, 7 Jan 2026 22:02:00 +0800 dwm: Fix heap buffer overflow in getatomprop When getatomprop() is called, it invokes XGetWindowProperty() to retrieve an Atom. If the property exists but has zero elements (length 0), Xlib returns Success and sets p to a valid, non-NULL memory address containing a single null byte. However, dl (that is, the number of items) is 0. dwm blindly casts p to Atom* and dereferences it. While Xlib guarantees that p is safe to read as a string (that is, it is null-terminated), it does _not_ guarantee it is safe to read as an Atom (an unsigned long). The Atom type is a typedef for unsigned long. Reading an Atom (which thus will either likely be 4 or 8 bytes) from a 1-byte allocated buffer results in a heap buffer overflow. Since property content is user controlled, this allows any client to trigger an out of bounds read simply by setting a property with format 32 and length 0. An example client which reliably crashes dwm under ASAN: #include #include #include #include #include int main(void) { Display *d; Window root, w; Atom net_wm_state; d = XOpenDisplay(NULL); if (!d) return 1; root = DefaultRootWindow(d); w = XCreateSimpleWindow(d, root, 10, 10, 200, 200, 1, 0, 0); net_wm_state = XInternAtom(d, "_NET_WM_STATE", False); if (net_wm_state == None) return 1; XChangeProperty(d, w, net_wm_state, XA_ATOM, 32, PropModeReplace, NULL, 0); XMapWindow(d, w); XSync(d, False); sleep(1); XCloseDisplay(d); return 0; } In order to avoid this, check that the number of items returned is greater than zero before dereferencing the pointer.

drw.c: drw_scm_free: call free inside

2025-09-29T16:48:27Z

commit 50a1f3442edda4ce0d544f71fe0a7bb52917783b parent a91f292825d41b4c0aeb677d946e4bffd2f32813 Author: Hiltjo Posthuma Date: Mon, 29 Sep 2025 18:48:27 +0200 drw.c: drw_scm_free: call free inside Because drw_scm_create() allocates it.

cleanup schemes and colors

2025-09-27T10:10:17Z

commit a91f292825d41b4c0aeb677d946e4bffd2f32813 parent 129652e1e5f004b91ac04815a28e8c58e81998f4 Author: Hiltjo Posthuma Date: Sat, 27 Sep 2025 12:10:17 +0200 cleanup schemes and colors

config: make refreshrate for mouse move/resize a config option

2025-08-12T17:17:20Z

commit 129652e1e5f004b91ac04815a28e8c58e81998f4 parent 7a4394c185f71780d29a956ff9897bc3e7288339 Author: Hiltjo Posthuma Date: Tue, 12 Aug 2025 19:17:20 +0200 config: make refreshrate for mouse move/resize a config option Bump the default from 60 to 120.

bump version to 6.6

2025-08-09T12:34:03Z

commit 7a4394c185f71780d29a956ff9897bc3e7288339 parent 69ff9961b57c95dff177179d1d3b366fcfa41665 Author: Hiltjo Posthuma Date: Sat, 9 Aug 2025 14:34:03 +0200 bump version to 6.6

Avoid unsigned integer underflow in drw_text()

2024-10-28T00:34:55Z

commit 69ff9961b57c95dff177179d1d3b366fcfa41665 parent bb04970abe9c405d6118f68ec88635fe12f063cc Author: Raymond Cole Date: Mon, 28 Oct 2024 00:34:55 +0000 Avoid unsigned integer underflow in drw_text()

util.c: output function might override errno and thus affect perror()

2024-10-27T19:10:07Z

commit bb04970abe9c405d6118f68ec88635fe12f063cc parent 8227c3f6b22af1a8539e41fbcb833bebd5d1d832 Author: Hiltjo Posthuma Date: Sun, 27 Oct 2024 20:10:07 +0100 util.c: output function might override errno and thus affect perror() Original patch by Raymond Cole with some modifications, thanks!

sync drw.{c,h} from dmenu

2024-10-05T11:01:49Z

commit 8227c3f6b22af1a8539e41fbcb833bebd5d1d832 parent 687f89b9f73329728ef91712fa41b883f2bdbcfd Author: Hiltjo Posthuma Date: Sat, 5 Oct 2024 13:01:49 +0200 sync drw.{c,h} from dmenu - drw: minor improvement to the nomatches cache - overhaul utf8decoding and render invalid utf8 sequences as U+FFFD. Thanks NRK for these improvements!

Add missing void to updateclientlist definition

2024-06-08T10:36:15Z

commit 687f89b9f73329728ef91712fa41b883f2bdbcfd parent 395dc58cec032bf2be703060923c97e0964ec3f9 Author: Pontus Stenetorp Date: Sat, 8 Jun 2024 19:36:15 +0900 Add missing void to updateclientlist definition Caught by -pedantic implying -Wstrict-prototypes for OpenBSD's 16.0.6 Clang.

bump version to 6.5

2024-03-19T11:13:16Z

commit 395dc58cec032bf2be703060923c97e0964ec3f9 parent ee140885c5096c434bbbb998785bb472980fc16a Author: Hiltjo Posthuma Date: Tue, 19 Mar 2024 12:13:16 +0100 bump version to 6.5

Makefile: remove the options target

2023-09-22T13:13:29Z

commit ee140885c5096c434bbbb998785bb472980fc16a parent 71659b66bb5d692215ecc98079cecc38d1b7a6be Author: Hiltjo Posthuma Date: Fri, 22 Sep 2023 15:13:29 +0200 Makefile: remove the options target The Makefile used to suppress output (by using @), so this target made sense at the time. But the Makefile should be simple and make debugging with less abstractions or fancy printing. The Makefile was made verbose and doesn't hide the build output, so remove this target. Prompted by a question on the mailing list about the options target.

restore SIGCHLD sighandler to default before spawning a program

2023-04-09T10:37:14Z

commit 71659b66bb5d692215ecc98079cecc38d1b7a6be parent df9ff60b2c5f0330daa02ba06b3240afdb8ceea8 Author: Hiltjo Posthuma Date: Sun, 9 Apr 2023 12:37:14 +0200 restore SIGCHLD sighandler to default before spawning a program From sigaction(2): A child created via fork(2) inherits a copy of its parent's signal dispositions. During an execve(2), the dispositions of handled signals are reset to the default; the dispositions of ignored signals are left unchanged. This refused to start directly some programs from configuring in config.h: static Key keys[] = { MODKEY, XK_o, spawn, {.v = cmd } }, }; Some reported programs that didn't start were: mpv, anki, dmenu_extended. Reported by pfx. Initial patch suggestion by Storkman.

config.mk: update to _XOPEN_SOURCE=700L

2023-02-17T05:05:09Z

commit df9ff60b2c5f0330daa02ba06b3240afdb8ceea8 parent a8d48d9f7a547d324501d9891a4002448eedbd21 Author: NRK Date: Fri, 17 Feb 2023 11:05:09 +0600 config.mk: update to _XOPEN_SOURCE=700L SA_NOCLDWAIT is marked as XSI in the posix spec [0] and FreeBSD and NetBSD seems to more be strict about the feature test macro [1]. so update the macro to use _XOPEN_SOURCE=700L instead, which is equivalent to _POSIX_C_SOURCE=200809L except that it also unlocks the X/Open System Interfaces. [0]: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html#tag_13_42 [1]: https://lists.suckless.org/dev/2302/35111.html Tested on: * NetBSD 9.3 (fixed). * FreeBSD 13 (fixed). * Void Linux musl. * Void Linux glibc. * OpenBSD 7.2 (stable). * Slackware 11. Reported-by: beastie

Use sigaction(SA_NOCLDWAIT) for SIGCHLD handling

2023-01-28T11:53:48Z

commit a8d48d9f7a547d324501d9891a4002448eedbd21 parent 23f5c6266ef52645955788026aa9ef8c935bd74c Author: Chris Down Date: Sat, 28 Jan 2023 12:53:48 +0100 Use sigaction(SA_NOCLDWAIT) for SIGCHLD handling signal() semantics are pretty unclearly specified. For example, depending on OS kernel and libc, the handler may be returned to SIG_DFL (hence the inner call to read the signal handler). Moving to sigaction() means the behaviour is consistently defined. Using SA_NOCLDWAIT also allows us to avoid calling the non-reentrant function die() in the handler. Some addditional notes for archival purposes: * NRK pointed out errno of waitpid could also theoretically get clobbered. * The original patch was iterated on and modified by NRK and Hiltjo: * SIG_DFL was changed to SIG_IGN, this is required, atleast on older systems such as tested on Slackware 11. * signals are not blocked using sigprocmask, because in theory it would briefly for example also ignore a SIGTERM signal. It is OK if waitpid() is (in theory interrupted). POSIX reference: "Consequences of Process Termination": https://pubs.opengroup.org/onlinepubs/9699919799/functions/_Exit.html#tag_16_01_03_01

grabkeys: Avoid missing events when a keysym maps to multiple keycodes

2022-12-07T14:55:08Z

commit 23f5c6266ef52645955788026aa9ef8c935bd74c parent 6cb076bb1f8ac08cae863af2fa10fc99ab1fd256 Author: Chris Down Date: Wed, 7 Dec 2022 14:55:08 +0000 grabkeys: Avoid missing events when a keysym maps to multiple keycodes It's not uncommon for one keysym to map to multiple keycodes. For example, the "play" button on my keyboard sends keycode 172, but my bluetooth headphones send keycode 208, both of which map back to XF86AudioPlay: % xmodmap -pke | grep XF86AudioPlay keycode 172 = XF86AudioPlay XF86AudioPause XF86AudioPlay XF86AudioPause keycode 208 = XF86AudioPlay NoSymbol XF86AudioPlay keycode 215 = XF86AudioPlay NoSymbol XF86AudioPlay This is a problem because the current code only grabs a single one of these keycodes, which means that events for any other keycode also mapping to the bound keysym will not be handled by dwm. In my case, this means that binding XF86AudioPlay does the right thing and correctly handles my keyboard's keys, but does nothing on my headphones. I'm not the only person affected by this, there are other reports[0]. In order to fix this, we look at the mappings between keycodes and keysyms at grabkeys() time and pick out all matching keycodes rather than just the first one. The keypress() side of this doesn't need any changes because the keycode gets converted back to a canonical keysym before any action is taken. 0: https://github.com/cdown/dwm/issues/11

Revert "Remove dmenumon variable"

2022-10-28T14:37:56Z

commit 6cb076bb1f8ac08cae863af2fa10fc99ab1fd256 parent eefb0cb72b715a34aad0612724f426d996032537 Author: Hiltjo Posthuma Date: Fri, 28 Oct 2022 16:37:56 +0200 Revert "Remove dmenumon variable" This reverts commit 4a0e6aed056c1d76d36af1f29713864ec00fcf6f. Revert back this change. It seems to not be an edge-case anymore since multiple users have asked about this new behaviour now.

bump version to 6.4

2022-10-04T17:35:13Z

commit eefb0cb72b715a34aad0612724f426d996032537 parent 4e9bbf9e2ac5ac7e3135c566a228516f6dbc7e82 Author: Hiltjo Posthuma Date: Tue, 4 Oct 2022 19:35:13 +0200 bump version to 6.4

remove workaround for a crash with color emojis on some systems, now fixed in libXft 2.3.5

2022-09-16T21:06:47Z

commit 4e9bbf9e2ac5ac7e3135c566a228516f6dbc7e82 parent 4a0e6aed056c1d76d36af1f29713864ec00fcf6f Author: Hiltjo Posthuma Date: Fri, 16 Sep 2022 23:06:47 +0200 remove workaround for a crash with color emojis on some systems, now fixed in libXft 2.3.5 https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS

Remove dmenumon variable

2022-08-26T12:48:46Z

commit 4a0e6aed056c1d76d36af1f29713864ec00fcf6f parent cfdd59578176fba7b212763ea0e64465c5e00e03 Author: Stein Date: Fri, 26 Aug 2022 14:48:46 +0200 Remove dmenumon variable Reasoning: Since 2011 dmenu has been capable of working out which monitor currently has focus in a Xinerama setup, making the use of the -m flag more or less redundant. This is easily demonstrated by using dmenu in any other window manager. There used to be a nodmenu patch that provided these changes: https://git.suckless.org/sites/commit/ed68e3629de4ef2ca2d3f8893a79fb570b4c0cbc.html but this was removed on the basis that it was very easy to work out and apply manually if needed. The proposal here is to remove this dependency from dwm. The mechanism of the dmenumon variable could be provided via a patch if need be. The edge case scenario that dmenu does not handle on its own, and the effect of removing this mechanism, is that if the user trigger focusmon via keybindings to change focus to another monitor that has no clients, then dmenu will open on the monitor containing the window with input focus (or the monitor with the mouse cursor if no windows have input focus). If this edge case is important to cover then this can be addressed by setting input focus to selmon->barwin in the focus function if there is no client to give focus to (rather than giving focus back to the root window).

config.def.h: make keys and buttons const

2022-08-18T16:13:08Z

commit cfdd59578176fba7b212763ea0e64465c5e00e03 parent 575dc056b5ab2896ff8d48b3891555bce30565af Author: NRK Date: Thu, 18 Aug 2022 22:13:08 +0600 config.def.h: make keys and buttons const pretty much all other variables are declared as const when they're not modified.

Remove blw variable in favour of calculating the value when needed

2022-08-15T12:31:22Z

commit 575dc056b5ab2896ff8d48b3891555bce30565af parent b0597d2bbf828887209e117c8e579e6995f4673f Author: Stein Date: Mon, 15 Aug 2022 14:31:22 +0200 Remove blw variable in favour of calculating the value when needed The purpose and reasoning behind the bar layout width (blw) variable in dwm the way it is today may not be immediately obvious. The use of the variable makes more sense when looking at commit 2ce37bc from 2009 where blw was initialised in the setup function and it represented the maximum of all available layout symbols. for(blw = i = 0; LENGTH(layouts) > 1 && i < LENGTH(layouts); i++) { w = TEXTW(layouts[i].symbol); blw = MAX(blw, w); } As such the layout symbol back then was fixed in size and both drawbar and buttonpress depended on this variable. The the way the blw variable is set today in drawbar means that it merely caches the size of the layout symbol for the last bar drawn. While unlikely to happen in practice it is possible that the last bar drawn is not that of the currently selected monitor, which can result in misaligned button clicks if there is a difference in layout symbol width between monitors.

Make floating windows spawn within the monitor's window area

2022-08-11T09:15:55Z

commit b0597d2bbf828887209e117c8e579e6995f4673f parent f01916dc1bd8b6f94150d10403eaeb153113c44c Author: Stein Date: Thu, 11 Aug 2022 11:15:55 +0200 Make floating windows spawn within the monitor's window area This is a follow-up on this thread: https://lists.suckless.org/hackers/2208/18462.html The orginal code had constraints such that if a window's starting attributes (position and size) were to place the window outside of the edges of the monitor, then the window would be moved into view at the closest monitor edge. There was an exception to this where if a top bar is used then the window should not obscure the bar if present, which meant to place the window within the window area instead. The proposed change here makes it the general rule that floating windows should spawn within the window area rather than within the monitor area. This makes it simple and consistent with no exceptions and it makes the intention of the code clear. This has the benefit of making the behaviour consistent regardless of whether the user is using a top bar or a bottom bar. Additionally this will have an effect on patches that modify the size of the window area. For example if the insets patch is used to reserve space on the left hand side of the monitor for a dock or a vertical bar then new floating clients will not obscure that area.

Simplify client y-offset correction

2022-08-09T08:38:08Z

commit f01916dc1bd8b6f94150d10403eaeb153113c44c parent 16bc12e35b497d38f9170a9a57db5044432dc17a Author: Stein Date: Tue, 9 Aug 2022 10:38:08 +0200 Simplify client y-offset correction The reasoning behind the original line may be lost to time as it does not make much sense checking the position on the x-axis to determine how to position the client on the y-axis. In the context of multi-monitor setups the monitor y position (m->my) may be greater than 0 (say 500), in which case the window could be placed out of view if: - the window attributes have a 0 value for the y position and - we end up using the y position of bh (e.g. 22) If the aim is to avoid a new floating client covering the bar then restricting y position to be at least that of the window area (m->wy) should cover the two cases of using a top bar and using a bottom bar.

sync code-style patch from libsl

2022-08-08T08:43:09Z

commit 16bc12e35b497d38f9170a9a57db5044432dc17a parent 9a039c0a1cb7314128e65de508c5d73483a46c27 Author: Hiltjo Posthuma Date: Mon, 8 Aug 2022 10:43:09 +0200 sync code-style patch from libsl

code-style: simplify some checks

2022-08-05T22:27:13Z

commit 9a039c0a1cb7314128e65de508c5d73483a46c27 parent aecae937bbba587df311630c16acafb0acd00d0d Author: NRK Date: Sat, 6 Aug 2022 04:27:13 +0600 code-style: simplify some checks main change here is making the `zoom()` logic saner. the rest of the changes are just small stuff which accumulated on my local branch. pop() must not be called with NULL. and `zoom()` achieves this, but in a very (unnecessarily) complicated way: if c == NULL then nexttiled() will return NULL as well, so we enter this branch: if (c == nexttiled(selmon->clients)) in here the !c check fails and the function returns before calling pop() if (!c || !(c = nexttiled(c->next))) return; however, none of this was needed. we can simply return early if c was NULL. Also `c` is set to `selmon->sel` so we can use `c` in the first check instead which makes things shorter.

spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

2022-07-29T23:26:04Z

commit aecae937bbba587df311630c16acafb0acd00d0d parent 76d746015b80f1fce2373fde7bed23f140983be0 Author: explosion-mental Date: Fri, 29 Jul 2022 18:26:04 -0500 spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :") when calling die and the last character of the string corresponds to ':', die() will call perror(). See util.c Also change EXIT_SUCCESS to EXIT_FAILURE

unmanage: stop listening for events for unmanaged windows

2022-08-01T09:42:44Z

commit 76d746015b80f1fce2373fde7bed23f140983be0 parent 3c43bd1c775bf1f9093bb979689d4c14132e92bc Author: Stein Date: Mon, 1 Aug 2022 11:42:44 +0200 unmanage: stop listening for events for unmanaged windows This is in particular to avoid flickering in dwm (and high CPU usage) when hovering the mouse over a tabbed window that was previously managed by dwm. Consider the following two scenarios: 1) We start tabbed (window 0xc000003), tabbed is managed by the window manager. We start st being embedded into tabbed. $ st -w 0xc000003 What happens here is that: - tabbed gets a MapRequest for the st window - tabbed reparents the st window - tabbed will receive X events for the window The window manager will have no awareness of the st window and the X server will not send X events to the window manager relating to the st window. There is no flickering or any other issues relating to focus. 2) We start tabbed (window 0xc000003), tabbed is managed by the window manager. We start st as normal (window 0xd400005). What happens here is that: - the window manager gets a MapRequest for the st window - dwm manages the st window as a normal client - dwm will receive X events for the window Now we use xdotool to trigger a reparenting of the st window into tabbed. $ xdotool windowreparent 0xd400005 0xc000003 What happens here is that: - tabbed gets a MapRequest for the st window - tabbed reparents the st window - the window manager gets an UnmapNotify - the window manager no longer manages the st window - both the window manager and tabbed will receive X events for the st window In dwm move the mouse cursor over the tabbed window. What happens now is that: - dwm will receive a FocusIn event for the tabbed window - dwm will set input focus for the tabbed window - tabbed will receive a FocusIn event for the main window - tabbed will give focus to the window on the currently selected tab - which again triggers a FocusIn event which dwm receives - dwm determines that the window that the FocusIn event is for (0xd400005) is not the currently selected client (tabbed) - dwm sets input focus for the tabbed window - this causes an infinite loop as long as the mouse cursor hovers the tabbed window, resulting in flickering and high CPU usage The fix here is to tell the X server that we are no longer interested in receiving events for this window when the window manager stops managing the window.

Revert "do not call signal-unsafe function inside sighanlder"

2022-07-22T07:18:52Z

commit 3c43bd1c775bf1f9093bb979689d4c14132e92bc parent 7aaac398b371885c8a892865e4d5076303e177f1 Author: Hiltjo Posthuma Date: Fri, 22 Jul 2022 09:18:52 +0200 Revert "do not call signal-unsafe function inside sighanlder" This reverts commit 7aaac398b371885c8a892865e4d5076303e177f1. Discussed on the mailinglist: https://lists.suckless.org/hackers/2207/18405.html

do not call signal-unsafe function inside sighanlder

2022-07-14T01:26:40Z

commit 7aaac398b371885c8a892865e4d5076303e177f1 parent 0d862487725077c188f65b351414379311aadf63 Author: NRK Date: Thu, 14 Jul 2022 07:26:40 +0600 do not call signal-unsafe function inside sighanlder die() calls vprintf, fputc and exit; none of these are async-signal-safe, see `man 7 signal-safety`.

use named parameter for func prototype

2022-07-14T01:27:34Z

commit 0d862487725077c188f65b351414379311aadf63 parent 20d8bfd2cf59c70499a84409957adbc20711278b Author: NRK Date: Thu, 14 Jul 2022 07:27:34 +0600 use named parameter for func prototype all the other prototypes use names.

sync latest drw.{c,h} changes from dmenu

2022-05-10T17:07:56Z

commit 20d8bfd2cf59c70499a84409957adbc20711278b parent d0c53d719b4defef0e2fc4e4be2f6da7eeab273a Author: Hiltjo Posthuma Date: Tue, 10 May 2022 19:07:56 +0200 sync latest drw.{c,h} changes from dmenu

Makefile: add manual path for OpenBSD

2022-05-01T16:37:54Z

commit d0c53d719b4defef0e2fc4e4be2f6da7eeab273a parent 77298e68c4cfe6836c4e8a4b165bfaa0ba171a31 Author: Hiltjo Posthuma Date: Sun, 1 May 2022 18:37:54 +0200 Makefile: add manual path for OpenBSD Reported by fossy , thanks

manage: Make sure c->isfixed is applied before floating checks

2022-04-26T08:42:23Z

commit 77298e68c4cfe6836c4e8a4b165bfaa0ba171a31 parent 08a37324fce7db4d751c5987436193082b7cd4e1 Author: Chris Down Date: Tue, 26 Apr 2022 09:42:23 +0100 manage: Make sure c->isfixed is applied before floating checks Commit b274e4936373 ("manage: propertynotify: Reduce cost of unused size hints") mistakenly removed an early size hints update that's needed to populate c->isfixed for floating checks at manage() time. This resulted in fixed (size hint min dimensions == max dimensions) subset of windows not floating when they should. See https://lists.suckless.org/dev/2204/34730.html for discussion.

LICENSE: add Chris Down

2022-04-26T13:50:32Z

commit 08a37324fce7db4d751c5987436193082b7cd4e1 parent f747127b786e43158d75c6b69f89cb7def0c9352 Author: Hiltjo Posthuma Date: Tue, 26 Apr 2022 15:50:32 +0200 LICENSE: add Chris Down

Revert "manage: For isfloating/oldstate check/set, ensure trans client actually exists"

2022-04-26T08:30:59Z

commit f747127b786e43158d75c6b69f89cb7def0c9352 parent f41c424da1491579254e53347190ffea60a0242e Author: Hiltjo Posthuma Date: Tue, 26 Apr 2022 10:30:59 +0200 Revert "manage: For isfloating/oldstate check/set, ensure trans client actually exists" This reverts commit 41a5ec907129a7b2de18e148bc9ec5f22fd3e8c9. It caused a regression, for example: https://lists.suckless.org/hackers/2203/18220.html

Update monitor positions also on removal

2022-02-21T14:58:28Z

commit f41c424da1491579254e53347190ffea60a0242e parent b274e49363731a91a61a5f965b1bf801a5d39c8f Author: Santtu Lakkala Date: Mon, 21 Feb 2022 16:58:28 +0200 Update monitor positions also on removal When monitors are removed, the coordinates of existing monitors may change, if the removed monitors had smaller coordinates than the remaining ones. Remove special case handling so that the same update-if-necessary loop is run also in the case when monitors are removed.

manage: propertynotify: Reduce cost of unused size hints

2022-03-17T15:56:13Z

commit b274e49363731a91a61a5f965b1bf801a5d39c8f parent 41a5ec907129a7b2de18e148bc9ec5f22fd3e8c9 Author: Chris Down Date: Thu, 17 Mar 2022 15:56:13 +0000 manage: propertynotify: Reduce cost of unused size hints This patch defers all size hint calculations until they are actually needed, drastically reducing the number of calls to updatesizehints(), which can be expensive when called repeatedly (as it currently is during resizes). In my unscientific testing this reduces calls to updatesizehints() by over 90% during a typical work session. There are no functional changes for users other than an increase in responsiveness after resizes and a reduction in CPU time. In slower environments or X servers, this patch also offers an improvement in responsiveness that is often tangible after resizing a client that changes hints during resizes. There are two main motivations to defer this work to the time of hint application: 1. Some clients, especially terminals using incremental size hints, resend XA_WM_NORMAL_HINTS events on resize to avoid fighting with the WM or mouse resizing. For example, some terminals like urxvt clear PBaseSize and PResizeInc during XResizeWindow and restore them afterwards. For this reason, after the resize is concluded, we typically receive a backlogged XA_WM_NORMAL_HINTS message for each update period with movement, which is useless. In some cases one may get hundreds or thousands of XA_WM_NORMAL_HINTS messages on large resizes, and currently all of these result in a separate updatesizehints() call, of which all but the final one are immediately outdated. (We can't just blindly discard these messages during resizes like we do for EnterNotify, because some of them might actually be for other windows, and may not be XA_WM_NORMAL_HINTS events.) 2. For users which use resizehints=0 most of these updates are unused anyway -- in the normal case where the client is not floating these values won't be used, so there's no need to calculate them up front. A synthetic test using the mouse to resize a floating terminal window from roughly 256x256 to 1024x1024 and back again shows that the number of calls to updatesizehints() goes from over 500 before this patch (one for each update interval with movement) to 2 after this patch (one for each hint application), with no change in user visible behaviour. This also reduces the delay before dwm is ready to process new events again after a large resize on such a client, as it avoids the thundering herd of updatesizehints() calls when hundreds of backlogged XA_WM_NORMAL_HINTS messages appear at once after a resize is finished.

manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-02-21T06:10:56Z

commit 41a5ec907129a7b2de18e148bc9ec5f22fd3e8c9 parent c838f93093296588bcaecd8fc2192e8d179ca8b1 Author: Miles Alan Date: Mon, 21 Feb 2022 01:10:56 -0500 manage: For isfloating/oldstate check/set, ensure trans client actually exists In certain instances trans may be set to a window that doesn't actually map to a client via wintoclient; in this case it doesn't make sense to set isfloating/oldstate since trans is essentially invalid in that case / correlates to the above condition check where trans is set / XGetTransientForHint is called.